core/dracut/ignition-ostree: add ignition-ostree-sysusers.service#2679
Open
HuijingHei wants to merge 3 commits intocoreos:testing-develfrom
Open
core/dracut/ignition-ostree: add ignition-ostree-sysusers.service#2679HuijingHei wants to merge 3 commits intocoreos:testing-develfrom
ignition-ostree-sysusers.service#2679HuijingHei wants to merge 3 commits intocoreos:testing-develfrom
Conversation
jlebon
reviewed
Oct 19, 2023
Member
jlebon
left a comment
There was a problem hiding this comment.
LGTM overall, though could we add an external test that tries to create a file owned by a user in a sysusers.d dropin? (E.g. zincati)
overlay.d/05core/usr/lib/dracut/modules.d/40ignition-ostree/ignition-ostree-sysusers.service
Outdated
Show resolved
Hide resolved
overlay.d/05core/usr/lib/dracut/modules.d/40ignition-ostree/coreos-sysroot-bwrap
Outdated
Show resolved
Hide resolved
Member
Author
Thanks @jlebon for the review! Do you mean like following (use |
420c8f7 to
5bf0de4
Compare
Member
Author
|
@jlebon I am not sure how I can add special test for this patch, as all systemd sysusers are generated during build process, any pointers? Thanks! |
5bf0de4 to
e762ba8
Compare
This introduces a new `coreos-sysroot-bwrap` helper in initramfs, for binaries that need to be executed with the final sysroot as a target, but before the pivot-root happens.
This introduces a new `ignition-ostree-sysusers.service`, which takes care of poulating users and groups on the target sysroot before the Ignition `files` stage.
e762ba8 to
bd54cd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #774.
Copy text here:
This introduces a new
ignition-ostree-sysusers.service, which takescare of poulating users and groups on the target sysroot before the
Ignitionfiles stage.