Skip to content

[next-devel] lockfiles: drop graduated overrides 🎓#3844

Merged
dustymabe merged 2 commits intocoreos:next-develfrom
coreosbot-releng:next-devel-graduation
Oct 24, 2025
Merged

[next-devel] lockfiles: drop graduated overrides 🎓#3844
dustymabe merged 2 commits intocoreos:next-develfrom
coreosbot-releng:next-devel-graduation

Conversation

@coreosbot-releng
Copy link

@coreosbot-releng coreosbot-releng commented Oct 22, 2025

Created by remove-graduated-overrides GitHub workflow (source).

@dustymabe
Copy link
Member

dustymabe commented Oct 22, 2025

This is weird. The https://bodhi.fedoraproject.org/updates/FEDORA-2025-db2c364f34 update didn't actually graduate, but was obsoleted instead. If I run

COSA_BUILD_WITH_BUILDAH=0 cosa fetch --update-lockfile --write-lockfile-to=foo.lock

I see:

linux-firmware-20251021-1.fc43.noarch (fedora-candidate-compose)

@dustymabe
Copy link
Member

dustymabe commented Oct 22, 2025

ok so I can't actually read dates correctly 20251021 is greater than 20251011 so it is right.

@dustymabe
Copy link
Member

dustymabe commented Oct 22, 2025

/ok-to-test

marmijo
marmijo previously approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travier
Copy link
Member

travier commented Oct 22, 2025

https://bodhi.fedoraproject.org/updates/FEDORA-2025-0b6e376195 is still in testing

@travier
Copy link
Member

travier commented Oct 22, 2025

So things that pulled form https://bodhi.fedoraproject.org/updates/FEDORA-2025-db2c364f34 should be updated to pull from https://bodhi.fedoraproject.org/updates/FEDORA-2025-0b6e376195 IIUC

@travier
Copy link
Member

travier commented Oct 22, 2025 •
edited
Loading 

linux-firmware-20251021-1.fc43.noarch (fedora-candidate-compose)

Ah, does this mean that this is in the special repo that is pulled for F43 RCs? and we include that as well?

@dustymabe
Copy link
Member

dustymabe commented Oct 22, 2025

Ah, does this mean that this is in the special repo that is pulled for F43 RCs? and we include that as well?

yes - see #3833

@dustymabe dustymabe enabled auto-merge (rebase) October 22, 2025 18:06
auto-merge was automatically disabled October 22, 2025 18:08

Head branch was pushed to by a user without write access

@dustymabe dustymabe force-pushed the next-devel-graduation branch from 2635bf0 to d3278c0 Compare October 22, 2025 19:46
coreosbot and others added 2 commits October 23, 2025 22:49
@coreosbot @dustymabe
lockfiles: drop graduated overrides 🎓
b1c2279 
Triggered by remove-graduated-overrides GitHub Action.
@dustymabe
overrides: remove arch specific graduated overrides
6f0228c 
These have graduated already so we can drop these files.
@dustymabe dustymabe force-pushed the next-devel-graduation branch from 8a5d975 to 6f0228c Compare October 24, 2025 02:49
marmijo
marmijo approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member

dustymabe commented Oct 24, 2025

i'll merge this soon and start a bump-lockfile job.

@dustymabe dustymabe merged commit 35bb498 into coreos:next-devel Oct 24, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marmijo marmijo marmijo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@coreosbot-releng @dustymabe @travier @marmijo @coreosbot