[next-devel] Move more things into build-args.conf#3985
[next-devel] Move more things into build-args.conf#3985dustymabe merged 1 commit intocoreos:next-develfrom
Conversation
A few sources of information were moved around/deleted in coreos#3978 so let's adjust our files here that need updating.
|
⛔ The |
dustymabe
changed the title
|
⛔ The |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the build configuration by centralizing several variables into build-args.conf and removing them from manifest.yaml. This includes moving stream information and the release version, which makes the configuration cleaner and more centralized. My review includes one suggestion to further improve maintainability by removing a potentially redundant variable.
| STREAM=next-devel | ||
| DESCRIPTION=Fedora CoreOS next-devel | ||
| VERSION=43 | ||
| MUTATE_OS_RELEASE=43 |
There was a problem hiding this comment.
The MUTATE_OS_RELEASE variable appears to be redundant. Its value is the same as the base version from the VERSION variable. To reduce configuration duplication, consider removing this variable and deriving its value from VERSION within the build-rootfs script (e.g., mutate_os_release = os.getenv('VERSION').split('.')[0]). This would make the configuration more maintainable.
|
/retest |
|
Looks like 43 is not in https://dl.fedoraproject.org/pub/fedora/linux/development/ anymore ? but was it there before ? 🤔 |
|
This branch isn't active right now so I don't expect tests to pass. We'll fix any issues with it when we re-enable |
2 participants
A few sources of information were moved around/deleted in #3978 so let's adjust our files here that need updating.