ci/overrides.py: support build-args.conf #4006
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request refactors how build arguments, stream names, and distribution tags are retrieved by introducing a new get_build_args function that reads values from build-args.conf using the dotenv library. This centralizes configuration retrieval and moves away from parsing manifest.yaml for these specific values, improving maintainability. The get_treefile function is also updated to use the build-rootfs parse-treefile command, leveraging the new build arguments. However, there are a couple of issues related to error handling for missing configuration keys and a functional change in the format of the distribution tag.
Now we get most information from the build-args.conf, but for things we don't let's use build-rootfs parse-treefile for that. Fixes coreos#4002
dustymabe
force-pushed
the
dusty-overrides-py
branch
from
4031edc to
da6d78e
Compare
aaradhak
left a comment
aaradhak
left a comment
There was a problem hiding this comment.
This LGTM. I had to spend some time to understand this.
|
followup in #4007 |
2 participants
Now we get most information from the build-args.conf, but for things we don't let's use build-rootfs parse-treefile for that.
Fixes #4002