Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions platforms.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ aarch64:
kernel_arguments:
- console=tty0
- console=ttyAMA0,115200n8
hetzner:
# Related issue: https://github.com/coreos/fedora-coreos-tracker/issues/1959
grub_commands:
- serial --speed=115200
- terminal_input serial console
- terminal_output serial console
kernel_arguments:
- console=tty1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other platform configurations in this file, please consider using console=tty0 instead of console=tty1. tty0 is used for the virtual console across all other platform definitions here. If tty1 is specifically required for Hetzner aarch64 systems, it would be helpful to add a comment explaining why.

      - console=tty0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why - it's just what I saw all the other OSes using. I listed /proc/cmdline outputs in this comment

- console=ttyS0,115200n8
openstack:
# Graphical console primary, serial console available for logging
# https://docs.openstack.org/diskimage-builder/latest/elements/bootloader/README.html
Expand Down