DNM: tests: add integrationtest to testing-devel #4010
Conversation
|
/test |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new integration test scenario for testing-devel. The changes are straightforward, adding a new Kustomization resource and the corresponding IntegrationTestScenario definition. My feedback focuses on clarifying the intended optional status of the test and addressing hardcoded version numbers to improve maintainability and prevent potential issues with outdated test configurations.
| # Remove this label if testing is not optional. | ||
| # test.appstudio.openshift.io/optional: "true" |
There was a problem hiding this comment.
The label test.appstudio.openshift.io/optional: "true" is currently commented out. If this integration test is intended to be optional, please uncomment this label. If it's meant to be a mandatory test, then the comment on line 7 should be removed to avoid confusion.
test.appstudio.openshift.io/optional: "true"| - name: url | ||
| value: https://gitlab.com/testing-farm/integrations-konflux | ||
| - name: revision | ||
| value: v3.16 |
There was a problem hiding this comment.
The revision for the resolverRef is hardcoded to v3.16. The introductory comment on line 2 suggests setting the pipeline_tag to the "latest available tag". Hardcoding specific versions can lead to outdated tests if the upstream repository updates. Consider updating this value to the current latest tag or implementing a mechanism to fetch the latest version dynamically. If v3.16 is intentionally fixed for this specific test, please add a comment to clarify this.
value: v3.16 # Fixed version for this test scenario.| value: RHEL-9-Nightly | ||
| - name: ARCH | ||
| value: x86_64 | ||
| - name: IMAGE_TAG |
There was a problem hiding this comment.
Similar to the revision field, the IMAGE_TAG parameter is also hardcoded to v3.16. Please ensure this value is kept up-to-date with the latest available tag, or add a clarifying comment if v3.16 is a fixed version for this test.
value: v3.16 # Fixed version for this test scenario.
|
/retest |
1 similar comment
|
/retest |
Roshan-R
force-pushed
the
kola-testing-farm
branch
from
fa906d1 to
95479fa
Compare
Roshan-R
force-pushed
the
kola-testing-farm
branch
from
95479fa to
5aebd95
Compare
1 participant
No description provided.