Skip to content

[next-devel] lockfiles: drop graduated overrides 🎓#4082

Merged
dustymabe merged 1 commit intocoreos:next-develfrom
coreosbot-releng:next-devel-graduation
Mar 31, 2026
Merged

[next-devel] lockfiles: drop graduated overrides 🎓#4082
dustymabe merged 1 commit intocoreos:next-develfrom
coreosbot-releng:next-devel-graduation

Conversation

@coreosbot-releng
Copy link
Copy Markdown

Created by remove-graduated-overrides GitHub workflow (source).

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several 'fast-track' package overrides from manifest-lock.overrides.yaml. Feedback was provided regarding inconsistencies for the ngtcp2 and selinux-policy suites, as the override versions being removed do not match the versions currently in the lockfiles, indicating the overrides were never properly applied.

I am having trouble creating individual review comments. Click here to see my feedback.

manifest-lock.overrides.yaml (66-77)

medium

This PR removes 'fast-track' overrides, which is expected for graduated packages. However, there's an inconsistency for ngtcp2 and ngtcp2-crypto-gnutls.

The override is for version 1.21.0-1.fc44, but the manifest-lock.*.json files specify an older version, 1.19.0-2.fc44. This suggests the override was never actually applied to the lockfiles.

To maintain a clear and consistent repository state, it would be safer to first update the lockfiles to use the overridden version, and then remove the override once it has graduated. This would prevent potential confusion about which package versions are intended to be in use.

manifest-lock.overrides.yaml (84-95)

medium

Similar to the ngtcp2 packages, there is an inconsistency for selinux-policy and selinux-policy-targeted.

The override is for version 43.3-1.fc44, but the manifest-lock.*.json files specify an older version, 43.1-1.fc44.

This indicates the override was not applied to the lockfiles. It would be better to synchronize the lockfiles with the overrides before removing them to ensure predictable behavior and a consistent version history.

@coreosbot-releng coreosbot-releng force-pushed the next-devel-graduation branch 2 times, most recently from 6487883 to 214d5cf Compare March 31, 2026 00:33
Triggered by remove-graduated-overrides GitHub Action.
Copy link
Copy Markdown
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe merged commit 1482ede into coreos:next-devel Mar 31, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants