support conditionally building artifacts in an OSBuild stage #1055
Conversation
|
unfortunately building more in OSBuild is causing us to need a larger cache qcow: |
|
pushing up a new commit to see if we can make the linter happy - if it works I'll test it and squash. |
dustymabe
force-pushed
the
dusty-osbuild
branch
from
38dfb8d to
abc2f15
Compare
I don't think making the linter happy is going to happen. There are plenty of other similar errors in the same file. I'm going to ignore since I already tested this code. |
| def stable = shwrapCapture(''' | ||
| cosa shell -- bash -c ' | ||
| for buildextend in /usr/lib/coreos-assembler/cmd-buildextend-*; do | ||
| if [ "$(readlink -f ${buildextend})" == "/usr/lib/coreos-assembler/cmd-osbuild" ]; then | ||
| echo "${buildextend:42}" | ||
| fi | ||
| done | ||
| ' | ||
| ''').tokenize('\n') |
There was a problem hiding this comment.
Hmm, I wonder if we should fold this itself into cosa osbuild. E.g. we could have cosa osbuild --supported-platforms=(all|experimental|stable).
There was a problem hiding this comment.
I think I would if we planned this code to live long.. but I'm hoping to delete it in 6 months or less.
The platforms get removed from the list of artifacts to parallel buildextend on when they get built by OSBuild. So, no. The idea is that there isn't a no-op stage that happens later, however in practice right now both |
With us now building more in OSBuild in a single run [1] we need a larger cache2.qcow2 to hold more pipeline outputs concurrently. [1] coreos/fedora-coreos-pipeline#1055
With us now building more in OSBuild in a single run [1] we need a larger cache2.qcow2 to hold more pipeline outputs concurrently. [1] coreos/fedora-coreos-pipeline#1055
With coreos/coreos-assembler#3930 we can now build multiple artifacts/platforms in a single OSBuild call. Let's add support here for detecting what artifacts are supported to be built by OSBuild and build them using OSBuild. We segregate here "experimental" versus "stable" OSbuild built artifacts and add a pipecfg knob for opting into the "experimental" ones being built by OSBuild.
dustymabe
force-pushed
the
dusty-osbuild
branch
from
abc2f15 to
f3a1ec9
Compare
|
just reporting some results now that we are building applehv gcp and hyperv using OSBuild in Note the uncompressed size doesn't show up in the OSBuild releases The results here show that things didn't significantly change with the move to OSBuild. |
In the case where we were running multiple parallel tasks in the pipeline that were running VMs and accessing the cache qcow we needed this, but with [1] we are now consolidating all OSBuild pipeline tasks into single non-parallel invocations. [1] coreos/fedora-coreos-pipeline#1055
In the case where we were running multiple parallel tasks in the pipeline that were running VMs and accessing the cache qcow we needed this, but with [1] we are now consolidating all OSBuild pipeline tasks into single non-parallel invocations. [1] coreos/fedora-coreos-pipeline#1055
In the case where we were running multiple parallel tasks in the pipeline that were running VMs and accessing the cache qcow we needed this, but with [1] we are now consolidating all OSBuild pipeline tasks into single non-parallel invocations. [1] coreos/fedora-coreos-pipeline#1055
In the case where we were running multiple parallel tasks in the pipeline that were running VMs and accessing the cache qcow we needed this, but with [1] we are now consolidating all OSBuild pipeline tasks into single non-parallel invocations. [1] coreos/fedora-coreos-pipeline#1055
In the case where we were running multiple parallel tasks in the pipeline that were running VMs and accessing the cache qcow we needed this, but with [1] we are now consolidating all OSBuild pipeline tasks into single non-parallel invocations. [1] coreos/fedora-coreos-pipeline#1055 (cherry picked from commit 5ab44b8)
3 participants
With coreos/coreos-assembler#3930 we can now build multiple artifacts/platforms in a single OSBuild call. Let's add support here for detecting what artifacts are supported to be built by OSBuild and build them using OSBuild.
We segregate here "experimental" versus "stable" OSbuild built artifacts and add a pipecfg knob for opting into the "experimental" ones being built by OSBuild.