multi-arch-builders: extend AWS tofu bits to work for x86_64 or aarch64 #986
Conversation
dustymabe
commented
May 4, 2024
dustymabe
commented
- Now depending on which directory you are in it will do the right thing.
- Handles RHCOS versus FCOS gracefully
- Deletes old provisioning instructions from the README
- Now depending on which directory you are in it will do the right thing. - Handles RHCOS versus FCOS gracefully - Deletes old provisioning instructions from the README
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
One comment, but LGTM as is. Will let @ravanelli stamp it.
There was a problem hiding this comment.
Does TF support includes? I feel like it might be clearer to rename this file, move it one level up and have the aarch64 and x86_64 bits just define the arch and include this one?
|
@dustymabe I finally got the change to test it. I did a rebase and only add the IP suggestion, I will let you do the rebase. So we can merge it. |
ravanelli
left a comment
ravanelli
left a comment
There was a problem hiding this comment.
LGTM, let's rebase it. The new x86 in AWS as deployed using it.
| instance_type = "m6g.metal" | ||
| instance_type = local.instance_type | ||
| vpc_security_group_ids = [aws_security_group.sg.id] | ||
| subnet_id = local.aws_subnet_id |
There was a problem hiding this comment.
| subnet_id = local.aws_subnet_id | |
| subnet_id = local.aws_subnet_id | |
| private_ip = var.distro == "rhcos" ? (var.arch == "aarch64" ? "10.30.77.147" : "10.30.77.139") : null |
Let's add our fixed IPs here, so we do not need to update our othe confgs in case the IPs changing
There was a problem hiding this comment.
Or we can also pass them as we are passing the splunk part, maybe that's better
3 participants
