*: switch systemd & dropin Contents to Resource type#986
Draft
arithx wants to merge 1 commit intocoreos:mainfrom
Draft
*: switch systemd & dropin Contents to Resource type#986arithx wants to merge 1 commit intocoreos:mainfrom
arithx wants to merge 1 commit intocoreos:mainfrom
Conversation
Contributor
Author
|
Code itself isn't tested yet or final, wanted to get this up now to discuss the trade-off (no longer being able to validate unit & dropin contents during validation). |
Switching the Contents field to the Resource type allows additional flexibility when specifying unit contents.
lucab
reviewed
Jun 18, 2020
| @@ -121,9 +121,23 @@ The Ignition configuration is a JSON document conforming to the following specif | |||
| * **_enabled_** (boolean): whether or not the service shall be enabled. When true, the service is enabled. When false, the service is disabled. When omitted, the service is unmodified. In order for this to have any effect, the unit must have an install section. | |||
| * **_mask_** (boolean): whether or not the service shall be masked. When true, the service is masked by symlinking it to `/dev/null`. | |||
| * **_contents_** (string): the contents of the unit. | |||
Contributor
There was a problem hiding this comment.
s/string/object/ I think? Also, isn't this a major schema break?
Contributor
There was a problem hiding this comment.
Whoops, yeah. This would require us to move to spec 4.0.0. Arguably that's okay -- the change is still translatable, so we can support both 3.x and 4.0 in the same code -- but we've avoided incompatible changes so far. But it also makes the original use case harder to implement in handwritten configs, since they'd need to convert to data URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching the Contents field to the Resource type allows additional
flexibility when specifying unit contents.
This switch comes with the trade-off of no longer being able to
validate unit & dropin contents at validation time.
Closes #884