Add a try_fail_point! macro and use it in more places#4259
Merged
jmarrero merged 1 commit intocoreos:mainfrom Jan 12, 2023
Merged
Add a try_fail_point! macro and use it in more places#4259jmarrero merged 1 commit intocoreos:mainfrom
try_fail_point! macro and use it in more places#4259jmarrero merged 1 commit intocoreos:mainfrom
Conversation
When I was debugging https://issues.redhat.com/browse/OCPBUGS-2866 it would have been quite convenient to have a failpoint set up in the transaction init path, because I could have forcibly injected a sleep there. Add one there, and in a few other places I semi-randomly chose by skimming through the code. The cost of this is very low, but if we find other bugs in the future it will likely be useful. Further, we can and should start using failpoints to forcibly inject errors in our CI tests. Since movement on review of tikv/fail-rs#68 has been slow, we just copy the code into our repo for now.
cgwalters
force-pushed
the
failpoint-dbus
branch
from
56a7b6e to
aa8d7fb
Compare
Member
Author
|
To use this do e.g.: Then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was debugging https://issues.redhat.com/browse/OCPBUGS-2866 it would have been quite convenient to have a failpoint set up in the transaction init path, because I could have forcibly injected a sleep there.
Add one there, and in a few other places I semi-randomly chose by skimming through the code. The cost of this is very low, but if we find other bugs in the future it will likely be useful.
Further, we can and should start using failpoints to forcibly inject errors in our CI tests.
Since movement on review of tikv/fail-rs#68 has been slow, we just copy the code into our repo for now.