daemon: extend rpm-ostreed.service idle-timeout#5032
Open
lukewarmtemp wants to merge 1 commit intocoreos:mainfrom
Open
daemon: extend rpm-ostreed.service idle-timeout#5032lukewarmtemp wants to merge 1 commit intocoreos:mainfrom
lukewarmtemp wants to merge 1 commit intocoreos:mainfrom
Conversation
When making D-Bus calls to the rpm-ostreed.service, the service will always exit after the specified idle-timeout has passed from when the daemon was first created. Even if D-Bus calls are constantly being made, the idle-timeout will still be enforced. This commit subscribes to the bus, listening for new calls. If a call is detected, the idle-timeout is reset. The service will only stop after the idle-timeout has passed after the last call to the bus. Signed-off-by: Luke Yang <luyang@redhat.com>
lukewarmtemp
changed the title
cgwalters
requested changes
Jul 31, 2024
Member
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
I commented in the bug...let's centralize discussion of the overall problem there.
I'm marking as requested-changes not because there are specific code changes that need to be done yet, but because the bug needs discussion.
|
@lukewarmtemp: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When making D-Bus calls to the rpm-ostreed.service, the service will always exit after the specified idle-timeout has passed from when the daemon was first created. Even if D-Bus calls are constantly being made, the idle-timeout will still be enforced.
This commit subscribes to the bus, listening for new calls. If a call is detected, the idle-timeout is reset. The service will only stop after the idle-timeout has passed after the last call to the bus.
xref: https://issues.redhat.com/browse/RHEL-49603