app/db: Add --avail option to diff against available update#5561
Open
kairosci wants to merge 1 commit intocoreos:mainfrom
Open
app/db: Add --avail option to diff against available update#5561kairosci wants to merge 1 commit intocoreos:mainfrom
kairosci wants to merge 1 commit intocoreos:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the --avail option to rpm-ostree db diff, allowing users to compare a revision against the latest available update. The implementation correctly handles argument parsing, fetches the available update information via DBus, and determines the 'from' and 'to' revisions for the diff. The code is well-structured with good error handling. I have one suggestion regarding code duplication to improve long-term maintainability.
kairosci
force-pushed
the
db-diff-avail
branch
2 times, most recently
from
53249e0 to
013403d
Compare
Author
|
@jmarrero PTAL, thanks! |
kairosci
force-pushed
the
db-diff-avail
branch
from
013403d to
f8794ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
--availoption to therpm-ostree db diffcommand.When the
--availoption is used, the command identifies the latest available update cached on the system and performs a diff against it.Usage examples:
Diff booted deployment against the latest available update:
Diff a specific revision against the latest available update:
Note: This requires a cached update to be present (usually via
rpm-ostree upgrade --check).Closes: #1953