Merge pull request #2962 from coreshop/copilot/fix-information-exposure-issue

Fix information exposure in OrderInvoiceController and OrderShipmentController

Author: dpfaffenbauer

src/CoreShop/Bundle/OrderBundle/Controller/OrderInvoiceController.php

@@ -187,8 +187,7 @@ public function renderAction(Request $request): Response
                     'Content-Disposition' => 'inline; filename="invoice-' . $invoice->getId() . '.pdf"',
                 ];
             } catch (\Exception $e) {
-                $responseData = '<strong>' . $e->getMessage() . '</strong><br>trace: ' . $e->getTraceAsString();
-                $header = ['Content-Type' => 'text/html'];
+                return new Response('An error occurred while rendering the invoice.', 500, ['Content-Type' => 'text/html']);
             }
 
             return new Response($responseData, 200, $header);

src/CoreShop/Bundle/OrderBundle/Controller/OrderShipmentController.php

@@ -183,8 +183,7 @@ public function renderAction(Request $request): Response
                     'Content-Disposition' => 'inline; filename="shipment-' . $shipment->getId() . '.pdf"',
                 ];
             } catch (\Exception $e) {
-                $responseData = '<strong>' . $e->getMessage() . '</strong><br>trace: ' . $e->getTraceAsString();
-                $header = ['Content-Type' => 'text/html'];
+                return new Response('An error occurred while rendering the shipment.', 500, ['Content-Type' => 'text/html']);
             }
 
             return new Response($responseData, 200, $header);