Skip to content

Add multi-select drag & drop support for objectMultihref condition lists #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpfaffenbauer merged 3 commits into from
Jan 29, 2026
Merged

Add multi-select drag & drop support for objectMultihref condition lists #2960

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddc0b5a
Initial plan
Copilot Jan 29, 2026
1f01b82
feat: Add multi-select drag & drop support for condition lists
Copilot Jan 29, 2026
dbfac39
refactor: Use for-of loops instead of traditional for loops
Copilot Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 27 additions & 21 deletions src/CoreShop/Bundle/ResourceBundle/Resources/public/pimcore/js/object/objectMultihref.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,45 +153,51 @@ coreshop.object.objectMultihref = Class.create(pimcore.object.tags.manyToManyObj
return this.component.getEl().dom;
}.bind(this),
onNodeOver: function (overHtmlNode, ddSource, e, data) {
var record = data.records[0];
var data = record.data;
var fromTree = this.isFromTree(ddSource);

if (data.elementType == 'object' && this.dndAllowed(data, fromTree)) {
return Ext.dd.DropZone.prototype.dropAllowed;
} else {
return Ext.dd.DropZone.prototype.dropNotAllowed;
// Check if any of the records can be dropped
for (var i = 0; i < data.records.length; i++) {
Copy link
Copy Markdown
Member

@dpfaffenbauer dpfaffenbauer Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Expected a for-of loop instead of a for loop with this simple iteration.

Copy link
Copy Markdown
Contributor Author

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use for-of loop in dbfac39.

var recordData = data.records[i].data;
if (recordData.elementType === 'object' && this.dndAllowed(recordData, fromTree)) {
return Ext.dd.DropZone.prototype.dropAllowed;
}
}

return Ext.dd.DropZone.prototype.dropNotAllowed;
}.bind(this),
onNodeDrop: function (target, ddSource, e, data) {
var record = data.records[0];
var data = record.data;
var fromTree = this.isFromTree(ddSource);

// check if data is a treenode, if not allow drop because of the reordering
if (!fromTree) {
return true;
}

if (data.elementType != 'object') {
return false;
}
var addedAny = false;

if (this.dndAllowed(data, fromTree)) {
var initData = {
id: data.id,
path: data.path,
type: data.className
};
// Process all records in the drag selection
for (var i = 0; i < data.records.length; i++) {
Copy link
Copy Markdown
Member

@dpfaffenbauer dpfaffenbauer Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Expected a for-of loop instead of a for loop with this simple iteration.

Copy link
Copy Markdown
Contributor Author

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use for-of loop in dbfac39.

var recordData = data.records[i].data;

if (recordData.elementType !== 'object') {
continue;
}

if (!this.objectAlreadyExists(initData.id)) {
this.store.add(initData);
return true;
if (this.dndAllowed(recordData, fromTree)) {
var initData = {
id: recordData.id,
path: recordData.path,
type: recordData.className
};

if (!this.objectAlreadyExists(initData.id)) {
this.store.add(initData);
addedAny = true;
}
}
}

return false;
return addedAny;
}.bind(this)
});
}.bind(this));
Expand Down