tests(stream_io): Disambiguate Expires from X-Amz-Expires in regex
#188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangstar
approved these changes
May 23, 2025
| ] | ||
| V2_regex = [ | ||
| r"Expires=1[0-9]+", | ||
| r"(?<!X-Amz-)Expires=1[0-9]+", |
Contributor
There was a problem hiding this comment.
Any reason why you hardcode the 1 here?
Collaborator
Author
There was a problem hiding this comment.
I'm not sure why that's there. It was added by someone else without any explanation that I found, so I left it.
maresb
added a commit
to regro-cf-autotick-bot/tensorizer-feedstock
that referenced
this pull request
Jun 14, 2025
Error:
× missing field `script`
╭─[recipe/recipe.yaml:39:10]
38 │ python_version: ${{ python_min }}.*
39 │ ╭─▶ - files:
40 │ │ source:
41 │ │ - tests/
42 │ │ requirements:
43 │ │ run:
44 │ │ - pytest
45 │ │ - pytest-rerunfailures
46 │ │ - transformers >=4.27.1
47 │ │ - moto >=4.1.4,<5.0.0
48 │ │ - redis-py >=5.0.0
49 │ │ - if: not win
50 │ │ then:
51 │ │ - redis-server
52 │ │ - boto3
53 │ │ script:
54 │ │ # Redis tests are flaky, sometimes failing with:
55 │ │ # redis.exceptions.ConnectionError: Error 111 connecting to localhost:6381.
56 │ │ # Connection refused.
57 │ │ # I suspect that there's not enough startup time, so we retry a few times.
58 │ │ - if: linux
59 │ │ then:
60 │ │ # Skip test_download_url until <coreweave/tensorizer#188> is merged.
61 │ │ - pytest tests -vvv --reruns 2 --deselect tests/test_stream_io.py::TestS3::test_download_url
62 │ │
63 │ ├─▶ about:
· ╰──── here
64 │ homepage: https://github.com/coreweave/tensorizer
╰────
help: expected field `script` to be a list of commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disambiguate URL parsing in a unit test
This change fixes a unit test that was incorrectly failing. It was essentially verifying that the string
X-Amz-Expireswas present in a URL querystring, but thatExpireswasn't, but didn't properly account forExpiresbeing a substring ofX-Amz-Expires.It was slightly more nuanced than this, so it didn't fail 100% of the time. This changes the regex so that the search for the substring
Expiresdoes not match if it is preceded by the substringX-Amz-.This only fixes a unit test and does not require any updated release or changelog notes.