Fix for #2674 - Corrected sizes for alpha in RQKernel when using Deep GPs#2677
Merged
kayween merged 16 commits intocornellius-gp:mainfrom Nov 25, 2025
Merged
Fix for #2674 - Corrected sizes for alpha in RQKernel when using Deep GPs#2677kayween merged 16 commits intocornellius-gp:mainfrom
kayween merged 16 commits intocornellius-gp:mainfrom
Conversation
Adjust alpha handling in postprocess_rq function
kayween
requested changes
Nov 14, 2025
Collaborator
kayween
left a comment
kayween
left a comment
There was a problem hiding this comment.
Hi @mrlj-hash, thank you for the PR! I left some comments. Can you also update the PR description to include a brief summary (e.g., what was the bug and how it's fixed).
kayween
reviewed
Nov 14, 2025
Implement manual conditional unsqueezing of alpha Co-authored-by: Kaiwen Wu <37524685+kayween@users.noreply.github.com>
Need last_dim_is_batch parameter to do the conditional unsqueezing of alpha
Ensure consistent whitespace
Collaborator
|
@mrlj-hash It's recommended to install a linter locally (e.g., flake8) or a pre-commit hook aid your development, see CONTRIBUTING.md. (That way those minor lint errors in the github workflow can be fixed more easily.) |
kayween
approved these changes
Nov 22, 2025
Collaborator
|
@gpleiss This PR is in good shape now. Do you want to give it a stamp before I merge it? We'll probably need to do a squash merge as there are many small commits in the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the RQKernel for Deep GPs, a shape mismatch as described in #2674 occurs. This was identified to be a consequence of unsqueezing the alpha parameter one extra time in a for loop. The fix, ensuring consistent behaviour in deep GPs and other model families, is to unsqueeze alpha manually and conditionally based on flags diag and last_dim_is_batch.