Skip to content

Replace np.trapz with np.trapezoid for area calculation#2696

Closed
jacobrgardner wants to merge 1 commit intomainfrom
jacobrgardner-trapzfix
Closed

Replace np.trapz with np.trapezoid for area calculation#2696
jacobrgardner wants to merge 1 commit intomainfrom
jacobrgardner-trapzfix

Conversation

@jacobrgardner
Copy link
Member

For #2695

@jacobrgardner
Copy link
Member Author

Unit tests need an environment update too I guess: https://numpy.org/doc/2.4/reference/generated/numpy.trapezoid.html

@jacobrgardner
Copy link
Member Author

Hmm okay, we'd also need to bump the pytorch min version to 2.2 per this comment:

pip install "numpy<2" # Numpy 2.0 is not fully supported until PyTorch 2.2

@Balandat botorch's pyproject currently only requires 2.0.1, so y'all are kind of in this blast radius of this one line change potentially. Thoughts about this?

@Balandat
Copy link
Collaborator

Balandat commented Jan 9, 2026

@jacobrgardner torch 2.2 is two years old by now, I think it's fine to bump the requirement up to 2.2 we can do the same thing on the botorch side. That will help simplify some of our CI logic so that's a side benefit. cc @saitcakmak

@Balandat
Copy link
Collaborator

Superseded by #2721

@Balandat Balandat closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants