Replace np.trapz with np.trapezoid for area calculation#2696
Closed
jacobrgardner wants to merge 1 commit intomainfrom
Closed
Replace np.trapz with np.trapezoid for area calculation#2696jacobrgardner wants to merge 1 commit intomainfrom
jacobrgardner wants to merge 1 commit intomainfrom
Conversation
Member
Author
|
Unit tests need an environment update too I guess: https://numpy.org/doc/2.4/reference/generated/numpy.trapezoid.html |
Member
Author
|
Hmm okay, we'd also need to bump the pytorch min version to 2.2 per this comment: @Balandat botorch's pyproject currently only requires 2.0.1, so y'all are kind of in this blast radius of this one line change potentially. Thoughts about this? |
Collaborator
|
@jacobrgardner torch 2.2 is two years old by now, I think it's fine to bump the requirement up to 2.2 we can do the same thing on the botorch side. That will help simplify some of our CI logic so that's a side benefit. cc @saitcakmak |
Collaborator
|
Superseded by #2721 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2695