Fix potential bug with settings.debug.on()#2704
Merged
kayween merged 2 commits intocornellius-gp:mainfrom Jan 26, 2026
Merged
Conversation
I'm not quite sure about this one and I'd like to get a review please, but I think that debug is a class and can't be "debug()"
Contributor
Author
|
I'm not quite sure, but I thought of this because all the other times it's debug.on() as well without the "()", could you please review this @jacobrgardner thanks! 👍 |
kayween
approved these changes
Jan 26, 2026
Collaborator
kayween
left a comment
kayween
left a comment
There was a problem hiding this comment.
LGTM. We have used settings.debug.on() and settings.debug().on() inconsistently. Both should work because the state of this flag is stored as a class variable. But it's great to enforce consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not quite sure about this one and I'd like to get a review please, but I think that debug is a class and can't be "debug()"