Skip to content

improve error logs in journald reader #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
def merged 1 commit into from
Oct 5, 2025
Merged

improve error logs in journald reader #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions logs/journald_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,16 @@ func NewJournaldReader(journalPaths ...string) (*JournaldReader, error) {
var err error
for _, journalPath := range journalPaths {
if r.journal, err = sdjournal.NewJournalFromDir(journalPath); err != nil {
klog.Errorf("failed to get journal at %s: %s", journalPath, err)
continue
}
usage, err := r.journal.GetUsage()
if err != nil {
klog.Errorf("failed to read journal disk space usage at %s: %s", journalPath, err)
continue
}
if usage == 0 {
klog.Errorf("journal at %s is empty", journalPath)
r.journal = nil
continue
}
Expand Down
Loading