Juice Squeeze: fix irrational tile reordering across rows during drag#177
Merged
skyl merged 1 commit intocorpora-inc:mainfrom Feb 18, 2026
Merged
Juice Squeeze: fix irrational tile reordering across rows during drag#177skyl merged 1 commit intocorpora-inc:mainfrom
skyl merged 1 commit intocorpora-inc:mainfrom
Conversation
Replace index-based row assignment (Math.floor(globalIndex / blocksPerRow)) with width-based greedy packing in reflowSentenceBlocks() and row-preserving grouping in reflowSentenceBlocksAnimated(). This prevents unrelated tiles from jumping between rows during drag-and-drop in multi-row phrases. Also simplifies calculateSentenceRows() and fixes tap-to-place row-full check to use actual block widths instead of fixed counts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Math.floor(globalIndex / blocksPerRow)) with width-based greedy packing inreflowSentenceBlocks()for correct final layout after dropsentenceRowinreflowSentenceBlocksAnimated()to prevent unrelated tiles from jumping between rows during drag previewcalculateSentenceRows()and fix tap-to-place row-full check to use actual block widths instead of fixed countsgetSentenceBlocksPerRow()and associated constantsProblem
In multi-row phrases, dragging a tile from row 0 caused unrelated blocks from row 1 to irrationally jump up to row 0, scrambling the word order. This was caused by a fixed-count index-based row assignment algorithm that ignored actual block widths.
Test plan
🤖 Generated with Claude Code