Made audio SoundSelectionCycleMode ini reading not case sensitive

Added soundcyclemode to abort message if it's invalid
Cleaned up original changelog entry for it since it's misleading and no proper update was ever documented (oops)

Author: garethyr

CHANGELOG.md

@@ -838,7 +838,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 	AddSoundContainer = SoundContainer // Note that SoundContainers replace Sounds, so this can be used for things like FireSound = SoundContainer
 		PresetName = Preset Name Here
 
-		CycleMode = MODE_RANDOM (default) | MODE_FORWARDS // How the SoundContainer will cycle through its `SoundSets` whenever it's told to select a new one. The former is prior behaviour, the latter cycles through SoundSets in the order they were added.
+		SoundSelectionCycleMode = RANDOM (default) | FORWARDS | ALL // How the SoundContainer will cycle through its `SoundSets` whenever it's told to select a new one. The first is prior behaviour of picking sounds at random, the second cycles through SoundSets in the order they were added, and the third plays all SoundSets at once.
 
 		LoopSetting = -1 | 0 (default) | 1+ // How the SoundContainer loops its sounds. -1 means it loops forever, 0 means it plays once, any number > 0 means it plays once and loops that many times.
 

Entities/SoundSet.cpp

@@ -8,9 +8,9 @@ namespace RTE {
 	const std::string SoundSet::m_sClassName = "SoundSet";
 
 	const std::unordered_map<std::string, SoundSet::SoundSelectionCycleMode> SoundSet::c_SoundSelectionCycleModeMap = {
-		{"Random", SoundSelectionCycleMode::RANDOM},
-		{"Forwards", SoundSelectionCycleMode::FORWARDS},
-		{"All", SoundSelectionCycleMode::ALL}
+		{"random", SoundSelectionCycleMode::RANDOM},
+		{"forwards", SoundSelectionCycleMode::FORWARDS},
+		{"all", SoundSelectionCycleMode::ALL}
 	};
 
 /////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
@@ -103,6 +103,8 @@ namespace RTE {
 	SoundSet::SoundSelectionCycleMode SoundSet::ReadSoundSelectionCycleMode(Reader &reader) {
 		SoundSelectionCycleMode soundSelectionCycleModeToReturn;
 		std::string soundSelectionCycleModeString = reader.ReadPropValue();
+		std::locale locale;
+		for (char &character : soundSelectionCycleModeString) { character = std::tolower(character, locale); }
 
 		std::unordered_map<std::string, SoundSelectionCycleMode>::const_iterator soundSelectionCycleMode = c_SoundSelectionCycleModeMap.find(soundSelectionCycleModeString);
 		if (soundSelectionCycleMode != c_SoundSelectionCycleModeMap.end()) {
@@ -297,7 +299,7 @@ namespace RTE {
 						selectSoundForwards();
 						break;
 					default:
-						RTEAbort("Invalid sound selection sound cycle mode.");
+						RTEAbort("Invalid sound selection sound cycle mode. " + m_SoundSelectionCycleMode);
 						break;
 				}
 				RTEAssert(m_CurrentSelection.second >= 0 && m_CurrentSelection.second < selectedVectorSize, "Failed to select next sound, either none was selected or the selected sound was invalid.");