Fixed numerous issues with automovers that were causing inaccurate results and extreme lag

Author: Causeless

Data/Base.rte/Scenes/Objects/Bunkers/BunkerSystems/Automovers/Controller/Controller.lua

@@ -1,3 +1,4 @@
+require("Utilities");
 require("Scenes/Objects/Bunkers/BunkerSystems/Automovers/GlobalAutomoverFunctions");
 
 local automoverUtilityFunctions = {};
@@ -678,7 +679,7 @@ automoverUtilityFunctions.findClosestNode = function(self, positionToFindClosest
 	return closestNode;
 end
 
-automoverUtilityFunctions.findNodeWithShortestScenePath = function(self, positionToFindClosestNodeFor, nodeThatMustHaveConnectingAutomoverPath, checkThatPositionIsInsideNodeZoneBoxOrConnectingAreas, pathfinderTeam, pathfinderDigStrength)
+automoverUtilityFunctions.findNodeWithShortestScenePath = function(self, positionToFindClosestNodeFor, nodeToCheckForPathsFrom, checkThatPositionIsInsideNodeZoneBoxOrConnectingAreas, pathfinderTeam, pathfinderDigStrength)
 	local teamNodeTable = AutomoverData[self.Team].nodeData;
 	local teamTeleporterTable = AutomoverData[self.Team].teleporterNodes;
 
@@ -690,6 +691,7 @@ automoverUtilityFunctions.findNodeWithShortestScenePath = function(self, positio
 			nodeSatisfiesConditions = nodeData.zoneBox:IsWithinBox(positionToFindClosestNodeFor);
 			if not nodeSatisfiesConditions then
 				local connectingAreaDirectionToCheck = Directions.None;
+				local distanceToNode = SceneMan:ShortestDistance(node.Pos, positionToFindClosestNodeFor, self.checkWrapping);
 				if distanceToNode.Y + (nodeData.size.Y * 0.5) < 0 then
 					connectingAreaDirectionToCheck = Directions.Up;
 				elseif distanceToNode.Y - (nodeData.size.Y * 0.5) > 0 then
@@ -713,7 +715,7 @@ automoverUtilityFunctions.findNodeWithShortestScenePath = function(self, positio
 	while coroutine.status(shortestPathCoroutine) ~= "dead" do
 		local _, result = coroutine.resume(shortestPathCoroutine, potentialClosestNodes, positionToFindClosestNodeFor, pathfinderTeam, false, pathfinderDigStrength);
 		if result then
-			return result.key;
+			return result;
 		else
 			coroutine.yield();
 		end

Data/Base.rte/Utilities.lua

@@ -17,22 +17,25 @@ function FindStartPositionWithShortestPathToEndPosition(startPositions, endPosit
 
 	local closestStartPositionKey;
 	local closestStartPosition;
-	local totalCostToClosestStartPosition;
+	local totalCostToClosestStartPosition = 1/0;
 	local pathRequestsCompleted = 0;
+	local totalPathingRequests = 0;
 	for startPositionKey, startPosition in pairs(startPositions) do
 		SceneMan.Scene:CalculatePathAsync(
 			function(pathRequest)
-				if totalCostToClosestStartPosition == nil or pathRequest.TotalCost < totalCostToClosestStartPosition then
+				if pathRequest.TotalCost < totalCostToClosestStartPosition then
 					closestStartPositionKey = startPositionKey;
 					closestStartPosition = startPosition;
 					totalCostToClosestStartPosition = pathRequest.TotalCost;
 				end
 				pathRequestsCompleted = pathRequestsCompleted + 1;
-			end
-		, startPosition, endPosition, movePathToGround, digStrength, team);
+			end, 
+			startPosition, endPosition, movePathToGround, digStrength, team
+		);
+		totalPathingRequests = totalPathingRequests + 1;
 	end
 
-	while pathRequestsCompleted < #startPositions do
+	while pathRequestsCompleted < totalPathingRequests do
 		if totalCostToClosestStartPosition == 0 then
 			break;
 		end