Merged
Conversation
martindstone
requested review from
cristinabuenahora and
jreock
as code owners
cristinabuenahora
previously approved these changes
Jan 7, 2025
Contributor
cristinabuenahora
left a comment
cristinabuenahora
left a comment
There was a problem hiding this comment.
Mostly just nits around code readability
| ); | ||
|
|
||
| const entityPages = useMemo((): EntityPageI[] => { | ||
| if (!entityDefinition) return []; |
Contributor
There was a problem hiding this comment.
Readability nits:
Suggested change
| if (!entityDefinition) return []; | |
| if (!entityDefinition) { | |
| return []; | |
| } |
Comment on lines
40
to
41
| const entityPages: EntityPageI[] = []; | ||
| if (Array.isArray(entityDefinition.info?.["x-cortex-confluence"]?.pages)) { |
Contributor
There was a problem hiding this comment.
And some spacing for readability:
Suggested change
| const entityPages: EntityPageI[] = []; | |
| if (Array.isArray(entityDefinition.info?.["x-cortex-confluence"]?.pages)) { | |
| const entityPages: EntityPageI[] = []; | |
| if (Array.isArray(entityDefinition.info?.["x-cortex-confluence"]?.pages)) { |
Comment on lines
49
to
50
| } | ||
| if (entityDefinition.info?.["x-cortex-confluence"]?.pageID) { |
Contributor
There was a problem hiding this comment.
Suggested change
| } | |
| if (entityDefinition.info?.["x-cortex-confluence"]?.pageID) { | |
| } | |
| if (entityDefinition.info?.["x-cortex-confluence"]?.pageID) { |
Comment on lines
82
to
84
| if (isLoading) return <Loading />; | ||
| if (!baseConfluenceUrl) return <Instructions />; | ||
| if (errorStr) return <Notice>{errorStr}</Notice>; |
Contributor
There was a problem hiding this comment.
Same here for adding {} around return
cristinabuenahora
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Add the ability to see multiple Confluence pages linked to an entity
This PR
This PR adds the ability to link multiple Confluence pages to a Cortex entity
Checklists
Security