fix confluence links to open in new tab, improve rendering#46
Closed
martindstone wants to merge 1 commit intomasterfrom
Closed
fix confluence links to open in new tab, improve rendering#46martindstone wants to merge 1 commit intomasterfrom
martindstone wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
plugins/confluence-plugin/src/components/PageContent.tsx:197
- Directly mutating the 'contents' object may lead to unexpected rendering issues. Consider updating the state using a setter to ensure proper re-rendering.
contents[`${entityPage.id}`].body = fixHtml(contents[`${entityPage.id}`].body, baseConfluenceUrl);
|
stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Confluence pages containing links need to have their links modified so that they open in a new tab
This PR
modifies links found in the retrieved HTML so that they open in a new tab
Checklists
Security