Skip to content

Commit 874e8d1

Browse files
committed
delete unused code
Signed-off-by: SungJin1212 <[email protected]>
1 parent 02ebd93 commit 874e8d1

File tree

3 files changed

+14
-50
lines changed

3 files changed

+14
-50
lines changed

pkg/storegateway/parquet_bucket_store.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,10 @@ func (p *parquetBucketStore) Close() error {
4444
}
4545

4646
func (p *parquetBucketStore) SyncBlocks(ctx context.Context) error {
47-
// TODO: Implement it
4847
return nil
4948
}
5049

5150
func (p *parquetBucketStore) InitialSync(ctx context.Context) error {
52-
// TODO: Implement it
5351
return nil
5452
}
5553

pkg/storegateway/parquet_bucket_store_metrics.go

Lines changed: 0 additions & 29 deletions
This file was deleted.

pkg/storegateway/parquet_bucket_stores.go

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,9 @@ type ParquetBucketStores struct {
6262

6363
inflightRequests *cortex_util.InflightRequestTracker
6464

65-
parquetBucketStoreMetrics *ParquetBucketStoreMetrics
66-
cortexBucketStoreMetrics *CortexBucketStoreMetrics
67-
userScanner users.Scanner
68-
shardingStrategy ShardingStrategy
65+
cortexBucketStoreMetrics *CortexBucketStoreMetrics
66+
userScanner users.Scanner
67+
shardingStrategy ShardingStrategy
6968

7069
userTokenBucketsMu sync.RWMutex
7170
userTokenBuckets map[string]*cortex_util.TokenBucket
@@ -80,18 +79,17 @@ func newParquetBucketStores(cfg tsdb.BlocksStorageConfig, shardingStrategy Shard
8079
}
8180

8281
u := &ParquetBucketStores{
83-
logger: logger,
84-
cfg: cfg,
85-
limits: limits,
86-
bucket: cachingBucket,
87-
stores: map[string]*parquetBucketStore{},
88-
storesErrors: map[string]error{},
89-
chunksDecoder: schema.NewPrometheusParquetChunksDecoder(chunkenc.NewPool()),
90-
inflightRequests: cortex_util.NewInflightRequestTracker(),
91-
cortexBucketStoreMetrics: NewCortexBucketStoreMetrics(reg),
92-
shardingStrategy: shardingStrategy,
93-
userTokenBuckets: make(map[string]*cortex_util.TokenBucket),
94-
parquetBucketStoreMetrics: NewParquetBucketStoreMetrics(),
82+
logger: logger,
83+
cfg: cfg,
84+
limits: limits,
85+
bucket: cachingBucket,
86+
stores: map[string]*parquetBucketStore{},
87+
storesErrors: map[string]error{},
88+
chunksDecoder: schema.NewPrometheusParquetChunksDecoder(chunkenc.NewPool()),
89+
inflightRequests: cortex_util.NewInflightRequestTracker(),
90+
cortexBucketStoreMetrics: NewCortexBucketStoreMetrics(reg),
91+
shardingStrategy: shardingStrategy,
92+
userTokenBuckets: make(map[string]*cortex_util.TokenBucket),
9593
}
9694
u.userScanner, err = users.NewScanner(cfg.UsersScanner, bucketClient, logger, reg)
9795
if err != nil {
@@ -415,7 +413,6 @@ func (u *ParquetBucketStores) closeEmptyBucketStore(userID string) error {
415413
u.userTokenBucketsMu.Unlock()
416414
}
417415

418-
u.parquetBucketStoreMetrics.RemoveUserRegistry(userID)
419416
return bs.Close()
420417
}
421418

@@ -482,8 +479,6 @@ func (u *ParquetBucketStores) getOrCreateStore(userID string) (*parquetBucketSto
482479
}
483480

484481
u.stores[userID] = store
485-
reg := prometheus.NewRegistry()
486-
u.parquetBucketStoreMetrics.AddUserRegistry(userID, reg)
487482
return store, nil
488483
}
489484

0 commit comments

Comments
 (0)