[Querier] Add day range limit for LabelNames and LabelValues #6233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afhassan
force-pushed
the
get-labels-limit
branch
from
2d65a02 to
5d2297a
Compare
yeya24
reviewed
Sep 25, 2024
Signed-off-by: Ahmed Hassan <[email protected]>
Signed-off-by: Ahmed Hassan <[email protected]>
afhassan
force-pushed
the
get-labels-limit
branch
from
5d2297a to
70ae7b9
Compare
Signed-off-by: Ahmed Hassan <[email protected]>
|
Seems this broke the query with no parameters as we default to min time |
|
Unfortunately I think it breaks things as by default label names and label values can have no start and end parameters specified. So by default all those APIs without time range parameters will be denied. I think the behavior is not wrong but at current stage the behavior change breaks existing use cases. So we need to find another way around. Maybe fallback to a smaller time range and add a warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Check day range limit in LabelNames and LabelValues. Return query too long error if
MaxQueryLengthlimit is exceeded.