-
Notifications
You must be signed in to change notification settings - Fork 833
Add otlp exemplar ingestion test #6244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add otlp exemplar ingestion test #6244
Conversation
Signed-off-by: SungJin1212 <[email protected]>
@yeya24 |
@SungJin1212 I don't think OTLP protocol supports metadata as metadata is only a Prometheus thing |
@yeya24 |
https://github.com/prometheus/prometheus/blob/main/storage/remote/write_handler.go#L527 https://opentelemetry.io/docs/specs/otlp/ |
@yeya24 |
prometheus/prometheus#13439 @SungJin1212 We can cover metadata API after this upstream PR gets merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Great work. Just some nits
Add an otlp exemplar ingestion test.
Which issue(s) this PR fixes:
Fixes #6235
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]