Ruler: Add support for per-user external labels #6340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
component/rules
damnever
force-pushed
the
feat/external-labels
branch
2 times, most recently
from
8551250 to
24be605
Compare
damnever
changed the title
|
@rapphil @rajagopalanand Maybe u guys can take a look on this one? |
yeya24
reviewed
Nov 16, 2024
| return | ||
| } | ||
| if externalLabelsUpdated { | ||
| if err = r.notifierApplyExternalLabels(user, externalLabels); err != nil { |
There was a problem hiding this comment.
Can we have a test case to verify the notifier applies external labels successfully
There was a problem hiding this comment.
Discovered alertmanagers will be reset after applying the config: prometheus/prometheus#14987
damnever
force-pushed
the
feat/external-labels
branch
2 times, most recently
from
9d6bb66 to
8c543ae
Compare
|
not sure why the tests failed.. |
|
Saw the same test failure in https://github.com/cortexproject/cortex/actions/runs/11944198449/job/33295615418?pr=6353 so probably unrelated. I will retry the test |
|
We can try rebasing master to get #6357 |
damnever
force-pushed
the
feat/external-labels
branch
from
c518968 to
7b5b187
Compare
Signed-off-by: Xiaochao Dong (@damnever) <[email protected]>
Signed-off-by: Xiaochao Dong (@damnever) <[email protected]>
Signed-off-by: Xiaochao Dong (@damnever) <[email protected]>
damnever
force-pushed
the
feat/external-labels
branch
from
53951fb to
e4d2823
Compare
yeya24
approved these changes
Nov 30, 2024
rajagopalanand
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add support for per-user external labels, this currently applies only to alerting rules, but we may consider adding them to remote read in the future.
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]