Upgrade thanos version to fix store gateway buf reuse issue #6346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <[email protected]>
yeya24
commented
Nov 19, 2024
| fetcher, | ||
| deduplicateBlocksFilter, | ||
| ignoreDeletionMarkFilter, | ||
| c.compactorCfg.CompactionInterval, |
Contributor
Author
There was a problem hiding this comment.
They introduced a timeout for syncing metadatas. I just put compaction interval for now
Contributor
Author
|
Convert to draft to figure out the change in thanos-io/thanos#7886 first. Updated: Spoke with the Thanos PR author and we will just set to true |
Signed-off-by: Ben Ye <[email protected]>
Contributor
Author
|
Would be nice to reproduce this test failure. https://github.com/cortexproject/cortex/actions/runs/11917739431/job/33213764870?pr=6346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Upgrade Thanos version to thanos-io/thanos#7915 as it is an important bug fix for store gateway.
Relevant changes to us:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]