Skip to content

Conversation

@anna-tran
Copy link
Contributor

What this PR does:
Adds a new limit to distributor for the number of inflight ingester client requests and expose new gauge metric to measure the number of inflight requests.

Which issue(s) this PR fixes:
Fixes #6358

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with a nit

@anna-tran anna-tran force-pushed the client-inflight-request-limit branch from b55d352 to 2d3ab25 Compare November 27, 2024 18:09
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 27, 2024
@anna-tran anna-tran force-pushed the client-inflight-request-limit branch from 2d3ab25 to 2bb1ab6 Compare November 27, 2024 18:10
@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 27, 2024
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 27, 2024
@danielblando danielblando merged commit 8c053a3 into cortexproject:master Nov 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/distributor lgtm This PR has been approved by a maintainer size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add distributor global limit for ingester client requests

3 participants