Add hedged request to Store Gateway #6388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
Dec 3, 2024
SungJin1212
force-pushed
the
Add-hedged-request-to-Store-Gateway
branch
from
b5378b2 to
3994384
Compare
yeya24
approved these changes
Dec 3, 2024
Contributor
yeya24
left a comment
yeya24
left a comment
There was a problem hiding this comment.
Looks good. Just a small nit
SungJin1212
force-pushed
the
Add-hedged-request-to-Store-Gateway
branch
2 times, most recently
from
c595c0f to
cbd4232
Compare
yeya24
approved these changes
Dec 3, 2024
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Add-hedged-request-to-Store-Gateway
branch
from
cbd4232 to
dca3507
Compare
damnever
reviewed
Dec 5, 2024
| hrt.mu.Lock() | ||
| err = hrt.TDigest.Add(duration) | ||
| if err != nil { | ||
| return nil, err |
Member
Author
There was a problem hiding this comment.
Thanks, I made a PR here thanos-io/thanos#7962.
cc. @yeya24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds hedged requests to Store Gateway. It can reduce the tail latency between Store Gateway and Object store.
Which issue(s) this PR fixes:
Fixes #6343
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]