Skip to content

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Aug 7, 2025

What this PR does:

Pull new improvements on parquet common:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label Aug 7, 2025
Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 7, 2025
@friedrichg
Copy link
Member

--- FAIL: TestParquetQueryable_Limits (0.22s)
    --- FAIL: TestParquetQueryable_Limits/max_data_bytes_per_query_limit_hit (0.01s)
        parquet_queryable_test.go:547: 
            	Error Trace:	/__w/cortex/cortex/pkg/querier/parquet_queryable_test.go:547
            	Error:      	Error message not equal:
            	            	expected: "error materializing labels: materializer failed to materialize columns: would fetch too many data bytes: resource exhausted (used 1)"
            	            	actual  : "error materializing labels: failed to get column indexes: failed to materialize column indexes: would fetch too many data bytes: resource exhausted (used 1)"
            	Test:       	TestParquetQueryable_Limits/max_data_bytes_per_query_limit_hit
FAIL

Looks related

@alanprot
Copy link
Member

alanprot commented Aug 7, 2025

Indeed i changed this error message upstream! =/ @yeya24 is it ok just to change the test?

Signed-off-by: yeya24 <[email protected]>
@yeya24 yeya24 merged commit 6f9d0be into cortexproject:master Aug 8, 2025
33 of 34 checks passed
@yeya24 yeya24 deleted the update-parquet-common-lib branch August 8, 2025 01:43
aclaygray pushed a commit to aclaygray/cortex that referenced this pull request Aug 18, 2025
* update parquet common library to latest

Signed-off-by: yeya24 <[email protected]>

* fix test

Signed-off-by: yeya24 <[email protected]>

---------

Signed-off-by: yeya24 <[email protected]>
Signed-off-by: Andrew Gray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants