-
Notifications
You must be signed in to change notification settings - Fork 833
Override exporter: expose all fields that can be converted to float64 #6979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override exporter: expose all fields that can be converted to float64 #6979
Conversation
91aa01b
to
8c3af7f
Compare
please take a look @bogdan-st |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I don't have much to say other than LGTM
I like to export even default so we can have data of which value is actually configured, but for another point, I am worry about number of metrics that we gonna start generating. Do we want to start exposing all this metrics? Is there a valid cases for this? In cases where we have hundreds or thousands of tenants, this can explode. For prometheus that is not a real problem |
@danielblando |
@SungJin1212 |
5027a1c
to
6dda5f8
Compare
@danielblando |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tested this with this runtime.yaml
runtime.yaml
ingester_limits:
max_series: 4.8e+06
ingester_stream_chunks_when_using_blocks: true
overrides:
default:
compactor_blocks_retention_period: "0"
ingestion_burst_size: 200000
ingestion_rate: 10000
ingestion_tenant_shard_size: 3
max_global_series_per_metric: 20000
max_global_series_per_user: 150000
max_series_per_metric: 0
max_series_per_user: 0
ruler_max_rule_groups_per_tenant: 35
ruler_max_rules_per_rule_group: 20

Which I am ok with.
@SungJin1212 could you mention in the CHANGELOG that label
max_local_series_per_metric got renamed to max_series_per_metric
and
max_local_series_per_user got renamed to max_series_per_user
and also adjust the docs
cortex/docs/guides/overrides-exporter.md
Lines 59 to 60 in 0b9befb
cortex_overrides{limit_name="max_local_series_per_metric",user="user1"} 0 | |
cortex_overrides{limit_name="max_local_series_per_user",user="user1"} 0 |
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
Signed-off-by: SungJin1212 <[email protected]>
6dda5f8
to
3c8e003
Compare
@friedrichg |
The current
override-exporter
only exposes a limited set of fields. This PR changes the logic to expose all fields that can be converted to afloat64
type.For reviewers: Would it be better to expose only the metrics that have values different from their defaults?
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]