Skip to content

Add tracing to parquet bucket store #7125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+11 −1
Open

Add tracing to parquet bucket store #7125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
286bcd9
Add tracings to parquet bucket store
SungJin1212 Nov 25, 2025
27c3f62
fix lint
SungJin1212 Nov 25, 2025
5a0c54e
fix lint
SungJin1212 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## master / unreleased

* [FEATURE] StoreGateway: Introduces a new parquet mode. #7046
* [ENHANCEMENT] StoreGateway: Add tracings to parquet mode. #7125
* [ENHANCEMENT] Alertmanager: Upgrade alertmanger to 0.29.0 and add a new incidentIO integration. #7092
* [ENHANCEMENT] Querier: Add a `-querier.parquet-queryable-shard-cache-ttl` flag to add TTL to parquet shard cache. #7098
* [ENHANCEMENT] Ingester: Add `enable_matcher_optimization` config to apply low selectivity matchers lazily. #7063
Expand Down
11 changes: 10 additions & 1 deletion pkg/storegateway/parquet_bucket_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"

"github.com/cortexproject/cortex/pkg/util/spanlogger"
"github.com/cortexproject/cortex/pkg/util/validation"
)

Expand Down Expand Up @@ -73,12 +74,14 @@ func (p *parquetBucketStore) findParquetBlocks(ctx context.Context, blockMatcher

// Series implements the store interface for a single parquet bucket store
func (p *parquetBucketStore) Series(req *storepb.SeriesRequest, srv storepb.Store_SeriesServer) (err error) {
spanLog, ctx := spanlogger.New(srv.Context(), "ParquetBucketStore.Series")
defer spanLog.Finish()

matchers, err := storecache.MatchersToPromMatchersCached(p.matcherCache, req.Matchers...)
if err != nil {
return status.Error(codes.InvalidArgument, err.Error())
}

ctx := srv.Context()
resHints := &hintspb.SeriesResponseHints{}
var anyHints *types.Any

Expand Down Expand Up @@ -158,6 +161,9 @@ func (p *parquetBucketStore) Series(req *storepb.SeriesRequest, srv storepb.Stor

// LabelNames implements the store interface for a single parquet bucket store
func (p *parquetBucketStore) LabelNames(ctx context.Context, req *storepb.LabelNamesRequest) (*storepb.LabelNamesResponse, error) {
spanLog, ctx := spanlogger.New(ctx, "ParquetBucketStore.LabelNames")
defer spanLog.Finish()

matchers, err := storecache.MatchersToPromMatchersCached(p.matcherCache, req.Matchers...)
if err != nil {
return nil, status.Error(codes.InvalidArgument, err.Error())
Expand Down Expand Up @@ -213,6 +219,9 @@ func (p *parquetBucketStore) LabelNames(ctx context.Context, req *storepb.LabelN

// LabelValues implements the store interface for a single parquet bucket store
func (p *parquetBucketStore) LabelValues(ctx context.Context, req *storepb.LabelValuesRequest) (*storepb.LabelValuesResponse, error) {
spanLog, ctx := spanlogger.New(ctx, "ParquetBucketStore.LabelValues")
defer spanLog.Finish()

matchers, err := storecache.MatchersToPromMatchersCached(p.matcherCache, req.Matchers...)
if err != nil {
return nil, status.Error(codes.InvalidArgument, err.Error())
Expand Down
Loading