Refactor: extract parquet shard cache to parquetutil pkg #7146
+341
−296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
changed the title
yeya24
requested changes
Dec 11, 2025
pkg/util/parquetutil/cache.go
Outdated
| func newCacheMetrics(reg prometheus.Registerer) *cacheMetrics { | ||
| return &cacheMetrics{ | ||
| hits: promauto.With(reg).NewCounterVec(prometheus.CounterOpts{ | ||
| Name: "cortex_parquet_queryable_cache_hits_total", |
Contributor
There was a problem hiding this comment.
should we remove queryable from the metric name? Or you make cortex_parquet_queryable as a prefix to those metrics
Contributor
There was a problem hiding this comment.
I see you already have name as a label then we need to remove the parquet queryable prefix in metric name. Otherwise you make prefix configurable
pkg/util/parquetutil/cache.go
Outdated
| } | ||
|
|
||
| type CacheConfig struct { | ||
| ParquetQueryableShardCacheSize int `yaml:"parquet_queryable_shard_cache_size"` |
Contributor
There was a problem hiding this comment.
I think it should be parquet shard cache size not parquet queryable cache size... It is a cache for parquet shard which exists in parquet store gateway as well
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Refactor-move-parquet-shard-cache-to-dedicated-pkg
branch
from
f64b0a4 to
031650a
Compare
Member
Author
|
@yeya24 |
SungJin1212
force-pushed
the
Refactor-move-parquet-shard-cache-to-dedicated-pkg
branch
2 times, most recently
from
bc8a63d to
cc9eba7
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Refactor-move-parquet-shard-cache-to-dedicated-pkg
branch
from
cc9eba7 to
ea253e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the parquet shard cache implementation into a new dedicated package
pkg/util/parquetutil.This refactoring allows the shard cache logic to be reused by other components.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]