Skip to content

Gamepresets changes#501

Merged
Litogin merged 3 commits intocorvax-team:masterfrom
tau27:evac
Mar 5, 2026
Merged

Gamepresets changes#501
Litogin merged 3 commits intocorvax-team:masterfrom
tau27:evac

Conversation

@tau27
Copy link
Collaborator

@tau27 tau27 commented Feb 26, 2026

Описание PR

Измнены геймрулы и чёт ещё

Требования

Согласие с условиями

  • Я согласен с условиями LICENSE и CLA.

Критические изменения

Список изменений
🆑

  • wl-add: Добавлен минимум игроков у режима расширенного в размере 7 штук.
  • wl-remove: Удалены раундстарт граффити.
  • wl-tweak: Изменена задержка у голосования за шаттл до получаса.

Summary by CodeRabbit

  • New Features

    • Added dedicated timeout configuration for evacuation shuttle votes.
  • Configuration

    • Extended and Secret game presets now require a minimum of 5 players to start.
  • Style

    • Disabled graffiti decal variation effects.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

Warning

Rate limit exceeded

@tau27 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 14 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 45a2b03 and d462d7c.

📒 Files selected for processing (1)
  • Content.Shared/_WL/CCVars/WLCCVars.Vote.cs
📝 Walkthrough

Walkthrough

This PR adds a dedicated timeout configuration for evacuation shuttle votes by introducing a new VoteShuttleTimeout CVar and updating the vote manager to explicitly apply this timeout. Additionally, it disables a graffiti variation pass and adjusts minimum player counts for two game presets.

Changes

Cohort / File(s) Summary
Vote System Timeout Configuration
Content.Server/Voting/Managers/VoteManager.DefaultVotes.cs, Content.Shared/_WL/CCVars/WLCCVars.Vote.cs
Added new VoteShuttleTimeout CVar (default 1800s) and refactored evacuation shuttle vote timeout handling to use explicit timeout application instead of relying on the general flow default.
Game Configuration Updates
Resources/Prototypes/roundstart.yml, Resources/Prototypes/game_presets.yml
Disabled BasicDecalGraffitiVariationPass in roundstart configuration and added minimum player requirements (minPlayers: 5) to Extended and Secret game presets.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • corvax-team/ss14-wl#403 — Related vote configuration changes; this PR extends vote CVar controls with the new VoteShuttleTimeout variable.

Suggested labels

S: Untriaged, S: Needs Review, size/M

Suggested reviewers

  • Litogin
  • LEVELcat

Poem

🐰 Hops with glee through voting queues,
Timeouts set in careful hues,
Shuttles evacuate on time,
With config vars so sublime!
One graffiti pass takes a break,
While player counts we gently make.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Gamepresets changes' is overly vague and generic. While it partially relates to one aspect of the PR (game_presets.yml modifications), it ignores the majority of changes including shuttle vote timeout, graffiti removal, and vote manager modifications, making it insufficiently descriptive. Consider a more descriptive title such as 'Adjust evacuation shuttle vote timeout and game preset settings' that captures the primary changes across all modified files.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Content.Shared/_WL/CCVars/WLCCVars.Vote.cs`:
- Around line 32-33: Update the CVar key string for VoteShuttleTimeout to fix
the typo: replace the incorrect "vote.evacuation_shittle_vote_timeout" with
"vote.evacuation_shuttle_vote_timeout" in the CVarDef.Create call (symbol:
VoteShuttleTimeout / CVarDef.Create) so the configuration key matches the
intended "shuttle" spelling.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 18eacfa and 45a2b03.

📒 Files selected for processing (4)
  • Content.Server/Voting/Managers/VoteManager.DefaultVotes.cs
  • Content.Shared/_WL/CCVars/WLCCVars.Vote.cs
  • Resources/Prototypes/GameRules/roundstart.yml
  • Resources/Prototypes/game_presets.yml

@Litogin Litogin merged commit 30efed4 into corvax-team:master Mar 5, 2026
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants