Skip to content

Ushki for all#502

Open
tau27 wants to merge 3 commits intocorvax-team:masterfrom
tau27:ushki
Open

Ushki for all#502
tau27 wants to merge 3 commits intocorvax-team:masterfrom
tau27:ushki

Conversation

@tau27
Copy link
Collaborator

@tau27 tau27 commented Feb 26, 2026

Описание PR

Добавлены маркинги людям и андроидом

Почему / Баланс

Технические детали

Медиа

Требования

Согласие с условиями

  • Я согласен с условиями LICENSE и CLA.

Критические изменения

Список изменений

🆑

  • wl-add: Людям добавлены ушки и хвосты всех видов, что были у фелинидов.
  • wl-tweak: Андроидам добавлены те же недостающие хвосты и ушки

Summary by CodeRabbit

  • New Features

    • Expanded appearance options: many ear, tail, and facial markings for feline, fox/vulpine, tajaran and vulpkanin types are now available to Humans and Androids in addition to their native species.
    • Cyberlimb markings now include Android compatibility, increasing prosthetic cosmetic choices.
  • Chores

    • Updated cargo product pricing for the janitorial service item.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f64edbd and 9346349.

📒 Files selected for processing (1)
  • Resources/Prototypes/Catalog/Cargo/cargo_service.yml

📝 Walkthrough

Walkthrough

Expanded speciesRestriction lists across multiple mob customization marking YAMLs to allow additional species (Human and/or Android) for various ear, tail, and cyberlimb markings. No other fields or control flow were changed.

Changes

Cohort / File(s) Summary
Corvax Cat Markings
Resources/Prototypes/Corvax/Entities/Mobs/Customization/Markings/cat_parts.yml
Extended speciesRestriction for cat ear and tail markings from [Felinid] to [Felinid, Human, Android].
Corvax Fox / Tajaran / Vulpkanin (Corvax)
Resources/Prototypes/Corvax/Entities/Mobs/Customization/Markings/fox_parts.yml, .../Markings/tajaran.yml, .../Markings/vulpkanin.yml
Added Human to speciesRestriction for multiple fox/tajaran/vulpkanin ear and tail markings.
Vulpkanin (standard) — ears & tails
Resources/Prototypes/Entities/Mobs/Customization/Markings/Vulpkanin/vulpkanin_ears.yml, .../Vulpkanin/vulpkanin_tail.yml
Expanded speciesRestriction from [Vulpkanin] to [Vulpkanin, Human, Android, Felinid] for listed ear and tail markings; tail entries include inline comment # WL-Changes: Tails for all.
Cyberlimb Markings
Resources/Prototypes/Entities/Mobs/Customization/Markings/cyberlibs.yml
Added Android to speciesRestriction arrays across cyberlimb entries (other species preserved).
Cargo catalog change
Resources/Prototypes/Catalog/Cargo/cargo_service.yml
Adjusted ServiceJanitorial cost from 560 to 800 (inline comment WL-Changes: Cost fix).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

S: Untriaged

Suggested reviewers

  • Litogin
  • LEVELcat

Poem

🐰
I hopped through YAML, nose a-gleam,
Ears and tails now join the team.
Humans, bots, and felines play—
I munch a byte and bound away.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Ushki for all' is vague and does not clearly convey the main changes. While 'ushki' (Russian for 'ears') relates to one aspect of the PR, the title lacks specificity about what is being added and to whom. Consider a more descriptive title such as 'Add ear and tail markings for Humans and Androids' or 'Enable Felinid/Vulpkanin markings for all species' to clearly communicate the changeset scope.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Resources/Prototypes/Entities/Mobs/Customization/Markings/cyberlibs.yml`:
- Line 6: Replace the misspelled species identifier "Andriod" with the correct
"Android" across all cyberlimb entries in this file; specifically update any
speciesRestriction arrays (e.g., the key speciesRestriction in cyberlibs.yml)
and any other occurrences of the token Andriod so they match the actual Android
species identifier used elsewhere.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 18eacfa and 83de149.

📒 Files selected for processing (8)
  • Resources/Prototypes/Corvax/Entities/Mobs/Customization/Markings/cat_parts.yml
  • Resources/Prototypes/Corvax/Entities/Mobs/Customization/Markings/fox_parts.yml
  • Resources/Prototypes/Corvax/Entities/Mobs/Customization/Markings/tajaran.yml
  • Resources/Prototypes/Corvax/Entities/Mobs/Customization/Markings/vulpkanin.yml
  • Resources/Prototypes/Entities/Mobs/Customization/Markings/Vulpkanin/vulpkanin_ears.yml
  • Resources/Prototypes/Entities/Mobs/Customization/Markings/Vulpkanin/vulpkanin_tail.yml
  • Resources/Prototypes/Entities/Mobs/Customization/Markings/cat_parts.yml
  • Resources/Prototypes/Entities/Mobs/Customization/Markings/cyberlibs.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant