Skip to content

Fix UpdateRecords#504

Merged
Litogin merged 3 commits intocorvax-team:masterfrom
Litogin:smalfix
Mar 2, 2026
Merged

Fix UpdateRecords#504
Litogin merged 3 commits intocorvax-team:masterfrom
Litogin:smalfix

Conversation

@Litogin
Copy link
Collaborator

@Litogin Litogin commented Mar 1, 2026

Описание PR

Почему / Баланс

Технические детали

Медиа

Требования

Согласие с условиями

  • Я согласен с условиями LICENSE и CLA.

Критические изменения

Список изменений

Summary by CodeRabbit

  • Bug Fixes
    • Corrected Russian localization key for the Holy Empire so its translated name displays and resolves correctly.
    • Updated the Russian label for the country-edit entry (now showing the intended term) to ensure consistent display across records.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c404ceb and ad83e1e.

📒 Files selected for processing (1)
  • Resources/Locale/ru-RU/_WL/records/records.ftl

📝 Walkthrough

Walkthrough

Updated Russian locale keys and a confederation prototype reference: renamed records-confederation-holy-empire-of-edenrecords-confederation-holy-empire-of-edem and adjusted records-country-edit label text in ru-RU; prototype confederationRecords.yml now references the new key.

Changes

Cohort / File(s) Summary
Locale updates
Resources/Locale/ru-RU/_WL/records/records.ftl
Renamed localization key records-confederation-holy-empire-of-edenrecords-confederation-holy-empire-of-edem (value "Священная Империя Эдема"); updated public key records-country-edit text from "ГОСУДАРСТВО" to "ГРАЖДАНСТВО" (value semantics preserved).
Prototype reference
Resources/Prototypes/_WL/Records/confederationRecords.yml
Updated name for confederation HolyEmpireOfEden to reference records-confederation-holy-empire-of-edem instead of the old key.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

S: Needs Review

Suggested reviewers

  • LEVELcat
  • tau27

Poem

🐰 I hopped through keys both old and new,
Tweaked a name, and nudged a view,
"Edem" now sings where Eden stood,
A tiny change — all still good,
I nibble bugs and cheer for you!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix UpdateRecords' is vague and does not clearly describe the actual changes, which involve correcting localization key names and values in Russian locale files. Provide a more specific title that describes the actual changes, such as 'Fix localization keys in Russian records' or 'Correct holy empire confederation key spelling'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Resources/Locale/ru-RU/_WL/records/records.ftl`:
- Line 30: The Russian locale key was renamed to
records-confederation-holy-empire-of-edem while the prototype
confederationRecords.yml still references
records-confederation-holy-empire-of-eden; fix by either updating the prototype
entry in confederationRecords.yml to use
records-confederation-holy-empire-of-edem or restore backward compatibility in
the locale file by adding an alias mapping
records-confederation-holy-empire-of-eden to the same Russian string as
records-confederation-holy-empire-of-edem so both keys resolve.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d806e64 and 077b6cf.

📒 Files selected for processing (2)
  • Resources/Locale/ru-RU/_WL/records/records.ftl
  • Resources/Prototypes/_WL/Records/confederationRecords.yml

@Litogin Litogin merged commit 26e9ddf into corvax-team:master Mar 2, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant