feat!: use toolkit-lib for diff (#125) #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the diff and assembly processing to use the new
@aws-cdk/toolkit-liblibrary.This allows us to greatly simplify the logic that we have to maintain
and offload more work to the core library.
For example, this allows us to use the default CDK authentication
instead of trying to replicate it ourselves (see #62).
Couple of other changes that I've included in this PR since v2 allows me
a chance to make breaking changes.
BREAKING CHANGE: several breaking changes with details below
There are several breaking changes in this release.
noDiffForStageswithstackSelectionStrategy&stackSelectorPatternsThis uses the native selection stack filtering capability of
toolkit-liband should be a more robust option for users to filterstacks.
stackSelectorPatternsalso uses a multi-line input instead ofa comma delimited string input. To migrate from
noDiffForStagestostackSelectorPatternsyou can do this:diffMethodis changed tochange-setto match the cdkdefault behavior. This also changes the IAM Role used for diff from the
lookup-roleto thedeploy-role. To keep the old behavior you canspecify
diffMethod: template-onlyallowDestroyTypesandnoFailOnDestructiveChangesinput types werechanged from a comma delimited string to a multi-line string.
Closes #44
Fixes #62
Signed-off-by: github-actions github-actions@github.com
Co-authored-by: github-actions github-actions@github.comFixes #