chore: make integers errors more explicit #1314
Conversation
For easy debugging.
packages/math/src/integers.ts
Outdated
| public static fromString(str: string): Uint32 { | ||
| if (!str.match(/^[0-9]+$/)) { | ||
| throw new Error("Invalid string format"); | ||
| throw new Error("Invalid string format. Found: " + str); |
There was a problem hiding this comment.
Can you put the values in quotes? This makes it easier to find begin and end in the error messages and allows debugging empty string inputs.
Probably easier to write with a template string.
throw new Error(`Invalid string format. Found: '${str}'`);Thanks
There was a problem hiding this comment.
I had also thought about it, but I based it on
cosmjs/packages/math/src/integers.ts
Line 204 in 2c3b27e
I will adapt to reflect your suggestion.
packages/math/src/integers.ts
Outdated
| private constructor(data: BN) { | ||
| if (data.isNeg()) { | ||
| throw new Error("Input is negative"); | ||
| throw new Error("Input is negative. Found: " + data); |
There was a problem hiding this comment.
Does that give you a proper debug representation of a BN?
There was a problem hiding this comment.
I don't think so, I will adapt this with the call toString()
|
Should be good @webmaster128 |
|
any news @webmaster128? |
|
The integer classes recently got rewritten to use |
3 participants
For easy debugging.