Expose explicitSignerData for simulation method and reduce rpc node requests#1606
Open
DavideSegullo wants to merge 8 commits intocosmos:mainfrom
Open
Expose explicitSignerData for simulation method and reduce rpc node requests#1606DavideSegullo wants to merge 8 commits intocosmos:mainfrom
DavideSegullo wants to merge 8 commits intocosmos:mainfrom
Conversation
reduced the number of network request for signAndBroadcast, now fetch account info only once instead of two.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Is there a chance we’ll see this merged? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment when we want to perform a simulation, using the
simulatemethod exposed in theSigningCosmWasmClientandSigningCosmWasmClientclasses, it is not possible to specify thesequence, but a request is made each time to get it.However, this in practical use results in sending multiple requests to the RPC nodes, for example when we go to use the
signAndBroadcastmethod at the moment three requests are made to the nodes:simulationmethod)signmethod)So we make the same request twice in a row to get the account details, specifically
sequenceandaccountNumber.The goal of this PR is to remove this redundancy and reduce the number of requests made to nodes in the chain, also for anyone who build libraries based on cosmjs it's a good way to control this kind of node requests.