fix: prevent updating check state before mempool insert

[beer-1]

Description

Closes: #25543

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.23%. Comparing base (1cc55e6) to head (e7d3c85).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #25550   +/-   ##
=======================================
  Coverage   68.23%   68.23%           
=======================================
  Files         894      894           
  Lines       58149    58159   +10     
=======================================
+ Hits        39676    39685    +9     
- Misses      18473    18474    +1     

Files with missing lines	Coverage Δ
baseapp/baseapp.go	84.85% <100.00%> (+0.49%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[aljo242]

@beer-1 lint failing

[beer-1]

@aljo242 fixed!

[aljo242]

@beer-1 do you see any potential for performance overhead due to this?

[beer-1]

@beer-1 do you see any potential for performance overhead due to this?

I don't think this introduce any performance degradation because it is just changing order of execution

[beer-1]

comment to prevent stale closing

[mattac21]

confirming my understanding here, we need to set the multistore for mempoolCtx back to to msCache since we are now not writing msCache before calling mempool.Insert when in modeCheck. So if we do not use msCache as our multistore, mmempool.Insert may operate on a stale multistore. Once we do call commitAnteCache though, we are safe to use ctx again since its ms has now been updated.

[mattac21]

I modified the mempool.Insert call locally to use ctx instead of mempoolCtx and all of our unit tests still passed. Could you think of a unit test that would demonstrate this ms requirement? imo its not super clear from this logic that that is required (would probably be easiest with a mock mempool and ante handler just checking values in the ms).