feat(telemetry): export ExtraConfig and CosmosExtra types#26006
feat(telemetry): export ExtraConfig and CosmosExtra types#26006technicallyty merged 6 commits intomainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
|
These types should be considered highly unstable, thus the reason they're not exported. But I guess with v0.x versioning that doesn't matter. Ideally, otelconf supports all this stuff natively eventually |
True, but these types are practically exposed to the user anyway, so it makes sense to make the available for automation. I would rather have compilation errors than having to manually keep this in sync. |
|
Fair enough. We might want to give the types slightly better names |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26006 +/- ##
==========================================
- Coverage 59.80% 59.78% -0.02%
==========================================
Files 965 965
Lines 64229 64227 -2
==========================================
- Hits 38410 38397 -13
- Misses 25819 25830 +11
🚀 New features to boost your workflow:
|
Export the otel.yaml Cosmos extension types so external consumers (e.g. platform tooling) can programmatically build otel configs without maintaining manual YAML templates.
Rename CosmosExtra to SupplementalOptions since the config is not Cosmos-specific — it fills gaps in upstream otelconf. Drop the ExtraConfig/OTelConfig wrapper types and the double-parse in InitializeOpenTelemetry, keeping only SupplementalOptions as the single exported type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
21f448c to
b11604f
Compare
technicallyty
left a comment
There was a problem hiding this comment.
could you update the readme and the example config there too?
|
extraConfig→ExtraConfigandcosmosExtra→CosmosExtraso external consumers can programmatically construct thecosmos_extrasection ofotel.yamlwithout maintaining manual YAML templatesExtraConfigexplaining intended usage alongsideotelconf.OpenTelemetryConfiguration