feat(x/vm): add OpenTelemetry tracing #871
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technicallyty
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // validateAuthorization validates an EIP-7702 authorization against the state. | ||
| func (k *Keeper) validateAuthorization(auth *ethtypes.SetCodeAuthorization, state vm.StateDB, chainID *big.Int) (authority common.Address, err error) { | ||
| func (k *Keeper) validateAuthorization(ctx sdk.Context, auth *ethtypes.SetCodeAuthorization, state vm.StateDB, chainID *big.Int) (authority common.Address, err error) { | ||
| ctx, span := ctx.StartSpan(tracer, "validateAuthorization", trace.WithAttributes( |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
To fix the issue, simply do not assign the return value for ctx from the StartSpan call since the updated context is not used. This is done by replacing ctx, span := ctx.StartSpan(...) with _ , span := ctx.StartSpan(...), indicating that the updated context is intentionally ignored. This change should be made on line 654 of x/vm/keeper/state_transition.go. No additional imports or definitions are required. Functionality is preserved, while the code becomes clearer and static analysis warnings are resolved.
Suggested changeset
1
x/vm/keeper/state_transition.go
| @@ -651,7 +651,7 @@ | ||
|
|
||
| // validateAuthorization validates an EIP-7702 authorization against the state. | ||
| func (k *Keeper) validateAuthorization(ctx sdk.Context, auth *ethtypes.SetCodeAuthorization, state vm.StateDB, chainID *big.Int) (authority common.Address, err error) { | ||
| ctx, span := ctx.StartSpan(tracer, "validateAuthorization", trace.WithAttributes( | ||
| _, span := ctx.StartSpan(tracer, "validateAuthorization", trace.WithAttributes( | ||
| attribute.String("delegate_address", auth.Address.Hex()), | ||
| attribute.Int64("nonce", int64(auth.Nonce)), | ||
| )) |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds tracing to x/vm
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch