Skip to content

chore: add hidden folders to codespell #7808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gjermundgaraba merged 6 commits into from
Dec 31, 2024
Merged

chore: add hidden folders to codespell #7808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a191bf1
chore: add hidden folders to codespell
gjermundgaraba Dec 30, 2024
dc5381d
add .github to codespell
gjermundgaraba Dec 31, 2024
37e196d
fail code spell checker on PRs
gjermundgaraba Dec 31, 2024
82b1b62
fix spelling error in e2e gh action
gjermundgaraba Dec 31, 2024
4fa5d83
Merge branch 'main' into gjermund/add-hidden-folders-to-spell-checker
gjermundgaraba Dec 31, 2024
e6fd411
Merge branch 'main' into gjermund/add-hidden-folders-to-spell-checker
gjermundgaraba Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,6 @@ jobs:
chain-a-tag: '${{ needs.determine-image-tag.outputs.simd-tag }}'
chain-b-tag: '${{ needs.determine-image-tag.outputs.simd-tag }}'
# on regular PRs we won't run upgrade tests.
# NOTE: we are exluding TestTransferTestSuite as we run this full suite instead of each individual test.
# NOTE: we are excluding TestTransferTestSuite as we run this full suite instead of each individual test.
test-exclusions: 'TestUpgradeTestSuite,TestIBCWasmUpgradeTestSuite,TestTransferTestSuite,TestAuthzTransferTestSuite,TestTransferTestSuiteSendReceive,TestTransferTestSuiteSendEnabled,TestTransferLocalhostTestSuite,TestConnectionTestSuite,TestInterchainAccountsGovTestSuite,TestIncentivizedTransferTestSuite,TestTransferForwardingTestSuite'
temp-run-full-suite: true
4 changes: 2 additions & 2 deletions .github/workflows/spell-checker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
- name: Install codespell
run: pip install codespell
- name: Run codespell
continue-on-error: true
run: codespell -w --skip="*.pb.go,*.pb.gw.go,*.json,*.git,*.js,*.h,*.bin,go.sum,go.mod,.github,*.pdf,*.tla" --ignore-words=.github/.codespellignore
continue-on-error: ${{ github.event_name != 'pull_request' }}
run: codespell -w --skip="*.pb.go,*.pb.gw.go,*.json,*.git,*.js,*.h,*.bin,go.sum,go.mod,*.pdf,*.tla" --ignore-words=.github/.codespellignore --check-hidden
- uses: peter-evans/create-pull-request@v7
if: github.event_name != 'pull_request'
with:
Expand Down
4 changes: 2 additions & 2 deletions modules/core/04-channel/keeper/upgrade_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2492,8 +2492,8 @@ func (suite *KeeperTestSuite) TestAbortUpgrade() {
errorReceipt, found := channelKeeper.GetUpgradeErrorReceipt(suite.chainA.GetContext(), path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID)
suite.Require().True(found, "error receipt should be found")

if ue, ok := upgradeError.(*types.UpgradeError); ok {
suite.Require().Equal(ue.GetErrorReceipt(), errorReceipt, "error receipt does not match expected error receipt")
if upgradeError, ok := upgradeError.(*types.UpgradeError); ok {
suite.Require().Equal(upgradeError.GetErrorReceipt(), errorReceipt, "error receipt does not match expected error receipt")
}
} else {

Expand Down
Loading