fix: query handlers are ignoring accumulate flag#7831
Closed
charymalloju wants to merge 6 commits intocosmos:mainfrom
Closed
fix: query handlers are ignoring accumulate flag#7831charymalloju wants to merge 6 commits intocosmos:mainfrom
charymalloju wants to merge 6 commits intocosmos:mainfrom
Conversation
gjermundgaraba
requested changes
Jan 11, 2025
Contributor
gjermundgaraba
left a comment
There was a problem hiding this comment.
Thank you for this PR! This will be nice to get fixed.
I think the solution itself is correct, but I added some comments in the tests.
I have linked to the issue for the PR, in which I added one more location that has the same issue, so please fix that one and the test cases.
Contributor
|
Hi, thanks for the pr! do you have a link to another filtered paginate query that does something similar so we can compare to an existing query |
Contributor
|
@charymalloju, did you get a chance to look at the comment from Aditya above? |
Contributor
|
We've decided to hold off on this work as 0.52 has just been put on hold. I am very sorry for the inconvenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #7825
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.