chore(modules/transfer): Replace deprecated usage of AddressFromBech32 with address.Codec#7845
Closed
hungdinh82 wants to merge 6 commits intocosmos:mainfrom
Closed
chore(modules/transfer): Replace deprecated usage of AddressFromBech32 with address.Codec#7845hungdinh82 wants to merge 6 commits intocosmos:mainfrom
hungdinh82 wants to merge 6 commits intocosmos:mainfrom
Conversation
hungdinh82
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
Comment on lines
+352
to
+354
| addrCdc := addresscodec.NewBech32Codec(sdk.GetConfig().GetBech32AccountAddrPrefix()) | ||
| senderBytes, err := addrCdc.StringToBytes(data.Sender) | ||
| sender := sdk.AccAddress(senderBytes) |
Contributor
There was a problem hiding this comment.
the keeper should probably have an address codec as a field
e2e/testsuite/tx.go
Outdated
Comment on lines
162
to
164
| addrCdc := addresscodec.NewBech32Codec(cosmosChain.Config().Bech32Prefix) | ||
| senderBytes, err := addrCdc.StringToBytes(user.FormattedAddress()) | ||
| sender := sdk.AccAddress(senderBytes) |
Contributor
There was a problem hiding this comment.
probably should be a method on the E2ETestSuite type to avoid repeating this on L282-L289
Contributor
|
Hi @hungdinh82, I think we will just do this in the team because we are working on a timeline where we need to get things sorted rather quickly, but I appreciate the effort you've put into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #7835
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.