Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8415 +/- ##
==========================================
+ Coverage 61.62% 61.68% +0.05%
==========================================
Files 299 299
Lines 21462 21494 +32
==========================================
+ Hits 13227 13259 +32
Misses 7643 7643
Partials 592 592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
gjermundgaraba
left a comment
There was a problem hiding this comment.
Nice! I like the Common Mistakes section. We should be sure to update that as we see issues!
I left some comments on a few items that we can disucss :)
I wonder if there are more linters we can use with golangci-lint that would help us conform more closely to the google styleguide (separate PR for that if it exists).
Contributor
|
Nice work!! Just left a few comments |
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
356a28b to
374300c
Compare
gjermundgaraba
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will be a discussion place to finalize our updated style guide. With the unleash the builder initiative, and new people joining the team, it's high time we solidify best practices so that the code remains in high standard.
closes: #8372
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Include changelog entry when appropriate (e.g. chores should be omitted from changelog).Wrote unit and integration tests if relevant.Updated documentation (docs/) if anything is changed.Addedgodoccomments if relevant.Files changedin the GitHub PR explorer.