fix: support amino encoding on MsgRecoverClient (backport #8448)#8483
Merged
gjermundgaraba merged 2 commits intorelease/v8.8.xfrom Jun 19, 2025
Merged
fix: support amino encoding on MsgRecoverClient (backport #8448)#8483gjermundgaraba merged 2 commits intorelease/v8.8.xfrom
gjermundgaraba merged 2 commits intorelease/v8.8.xfrom
Conversation
Co-authored-by: Gjermund Garaba <gjermund@garaba.net> (cherry picked from commit de2f70a) # Conflicts: # modules/core/02-client/types/codec.go # modules/core/02-client/types/tx.pb.go
Contributor
Author
|
Cherry-pick of de2f70a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
gjermundgaraba
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds amino encoding support to
MsgRecoverClientso that txs that include this msg type can be signed via Ledger devices.It would be great if these changes could get backported to v8 as well.
closes: #8447
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) if anything is changed.godoccomments if relevant.Files changedin the GitHub PR explorer.This is an automatic backport of pull request #8448 done by [Mergify](https://mergify.com).