Skip to content

fix: support amino encoding on MsgRecoverClient (backport #8448)#8483

Merged
gjermundgaraba merged 2 commits intorelease/v8.8.xfrom
mergify/bp/release/v8.8.x/pr-8448
Jun 19, 2025
Merged

fix: support amino encoding on MsgRecoverClient (backport #8448)#8483
gjermundgaraba merged 2 commits intorelease/v8.8.xfrom
mergify/bp/release/v8.8.x/pr-8448

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jun 5, 2025

Description

This PR adds amino encoding support to MsgRecoverClient so that txs that include this msg type can be signed via Ledger devices.

It would be great if these changes could get backported to v8 as well.

closes: #8447


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Include changelog entry when appropriate (e.g. chores should be omitted from changelog).
  • Wrote unit and integration tests if relevant.
  • Updated documentation (docs/) if anything is changed.
  • Added godoc comments if relevant.
  • Self-reviewed Files changed in the GitHub PR explorer.
  • Provide a conventional commit message to follow the repository standards.

This is an automatic backport of pull request #8448 done by [Mergify](https://mergify.com).

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
(cherry picked from commit de2f70a)

# Conflicts:
#	modules/core/02-client/types/codec.go
#	modules/core/02-client/types/tx.pb.go
@mergify
Copy link
Contributor Author

mergify bot commented Jun 5, 2025

Cherry-pick of de2f70a has failed:

On branch mergify/bp/release/v8.8.x/pr-8448
Your branch is up to date with 'origin/release/v8.8.x'.

You are currently cherry-picking commit de2f70a4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   modules/core/module.go
	modified:   proto/ibc/core/client/v1/tx.proto

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   modules/core/02-client/types/codec.go
	both modified:   modules/core/02-client/types/tx.pb.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@gjermundgaraba gjermundgaraba merged commit 3ee2c4c into release/v8.8.x Jun 19, 2025
19 checks passed
@gjermundgaraba gjermundgaraba deleted the mergify/bp/release/v8.8.x/pr-8448 branch June 19, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants